-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit testing for duotone enhanced pagination. #55542
Add Unit testing for duotone enhanced pagination. #55542
Conversation
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/class-wp-duotone-test.php |
Flaky tests detected in 6003e20. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6613195641
|
Closing this PR, as the test is already in Core. |
Does Gutenberg run Core tests as well? |
As far as I remember, there are some people working on that. But it's not ready yet. Do you want to add them for future enhanced pagination features in Gutenberg? |
I think we should have all the tests in Gutenberg as well, yes 🙂 |
0c06ec3
to
59d098e
Compare
@luisherranz ready for review. It's the same code than Core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Carlos! 🎉
@c4rl0sbr4v0 Can I confirm that as per #55542 (comment) this does not require a backport for 6.5? |
Yep, this was committed long ago: |
What?
A follow up of #55415.
This PR adds automated testing to those previous PR changes.
I also added the test in the Core backport.
https://github.com/WordPress/wordpress-develop/pull/5540/files
Why?
To prevent unexpected crashes if duotone code changes.