Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit testing for duotone enhanced pagination. #55542

Merged

Conversation

cbravobernal
Copy link
Contributor

@cbravobernal cbravobernal commented Oct 23, 2023

What?

A follow up of #55415.
This PR adds automated testing to those previous PR changes.
I also added the test in the Core backport.
https://github.com/WordPress/wordpress-develop/pull/5540/files

Why?

To prevent unexpected crashes if duotone code changes.

@cbravobernal cbravobernal added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Colors Color management labels Oct 23, 2023
@cbravobernal cbravobernal self-assigned this Oct 23, 2023
@cbravobernal cbravobernal marked this pull request as ready for review October 23, 2023 12:26
@github-actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ phpunit/class-wp-duotone-test.php

@github-actions
Copy link

Flaky tests detected in 6003e20.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6613195641
📝 Reported issues:

@cbravobernal
Copy link
Contributor Author

Closing this PR, as the test is already in Core.
WordPress/wordpress-develop#5561

@luisherranz
Copy link
Member

Does Gutenberg run Core tests as well?

@cbravobernal
Copy link
Contributor Author

As far as I remember, there are some people working on that. But it's not ready yet. Do you want to add them for future enhanced pagination features in Gutenberg?

@luisherranz
Copy link
Member

I think we should have all the tests in Gutenberg as well, yes 🙂

@cbravobernal cbravobernal reopened this Nov 2, 2023
@cbravobernal cbravobernal force-pushed the update/add-unit-test-for-duotone-enhanced-pagination branch from 0c06ec3 to 59d098e Compare November 2, 2023 10:33
@cbravobernal
Copy link
Contributor Author

@luisherranz ready for review. It's the same code than Core.

@cbravobernal cbravobernal enabled auto-merge (squash) November 2, 2023 12:20
Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Carlos! 🎉

@cbravobernal cbravobernal merged commit 417eff2 into trunk Nov 6, 2023
49 checks passed
@cbravobernal cbravobernal deleted the update/add-unit-test-for-duotone-enhanced-pagination branch November 6, 2023 14:34
@github-actions github-actions bot added this to the Gutenberg 17.1 milestone Nov 6, 2023
@getdave
Copy link
Contributor

getdave commented Feb 1, 2024

@c4rl0sbr4v0 Can I confirm that as per #55542 (comment) this does not require a backport for 6.5?

@cbravobernal
Copy link
Contributor Author

Yep, this was committed long ago:
WordPress/wordpress-develop#5540 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants